Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): Make Tooltip positionStrategy actually work #1560

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix(web-react): Make Tooltip positionStrategy actually work #1560

merged 1 commit into from
Jul 24, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners July 23, 2024 15:36
@github-actions github-actions bot added the bug Something isn't working label Jul 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6598cce
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66a0b0bc90152b00088417f7
😎 Deploy Preview https://deploy-preview-1560--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 6598cce
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66a0b0bcf5c49d0008c1f2b2
😎 Deploy Preview https://deploy-preview-1560--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 23, 2024 •
edited
Loading

Coverage Status

coverage: 78.194% (+12.0%) from 66.205%
when pulling 6598cce on fix/tooltip-position-strategy
into f9a6be5 on main.

@literat literat force-pushed the fix/tooltip-position-strategy branch from 7912209 to 6598cce Compare July 24, 2024 07:43
literat
literat approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@literat literat merged commit 615c6b4 into main Jul 24, 2024
15 checks passed
@literat literat deleted the fix/tooltip-position-strategy branch July 24, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@crishpeen crishpeen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @coveralls @literat